Her character is not bad per say, but it's just run it's course.
Superman, the most powerful man in the world as to always be in control, or else anything he touches would crumple, that includes Lois.
Superman needs a Woman that his equal in all shit and form. A woman that can comfort him, or beat his ass when he's out of line, and that Woman is Wonder Woman.
One of the reason i like elseworlds is for that main fact. That pairing is one of the best in comic, and the authors knows it as well.
For example.
In the Dark Knight Returns when Clark was acting like a pussy what did Diana do, she ****ing kicked his ass, and then they had sex, and shook the north pole.
In Kingdom Come, Superman's general was Diana, she went to war with him, and she would die for him also.
In one of the main continuity, Clark, and Diana spent a 1000 yrs in Asgards fighting, they had killed Lois, but at the end the writers chicken out, and they returned them to the exact time they left.
So like i said, Lois is not a bad character, but Clark just needs someone that's his equal in all shape and form, and Lois is not that person.